Fix Translation not found when contains non-standard character#21
Open
N1ebieski wants to merge 1 commit intolaravel:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes laravel/vs-code-extension#400, probably fixes laravel/vs-code-extension#433, laravel/vs-code-extension#628
This PR is related to my previous PR #19
Stillat\BladeParser\Document\Document::fromTexttreats multibyte characters as indentations and spaces resulting in a miscalculated Node position. so my previous PR replaces all multibyte characters with a singlebyte placeholder.But if a user has any multibyte characters (symbols etc.) inside translations for example: (arrow → is a symbol)
{{ __('Where to find the ID: Log in to the dashboard, go to Products → Settings → Categories, then click Edit next to the selected category. The category ID can be found on the left side at the bottom of the form.') }}then
linkProvidercannot find such an element in the translation repository.This PR improves my previous PR. Only Node's
positionis being corrected. The Node'sinnerContentremains unchanged.